[Piglit] [PATCH] GL_ARB_draw_instanced/dlist: Fix crash

Eric Anholt eric at anholt.net
Wed Dec 7 19:20:23 UTC 2016

arthur.huillet at free.fr writes:

> From: Arthur Huillet <ahuillet at nvidia.com>
> The test was passing a NULL indices pointer without an element buffer bound. Nothing in the GL spec requires a NULL check, so drivers were free to crash before checking the error condition that the test attempts to check. Fix this by passing an index buffer.
> Also swap vertex counts and instance counts, which I suspect were mixed up in the test author's head. That part is strictly cosmetic and has no functional impact.

Commit messages should be wrapped at 80 columns-ish.  Other than that,

Reviewed-by: Eric Anohlt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161207/889db0d3/attachment.sig>

More information about the Piglit mailing list