[Piglit] [PATCH] fbo-maxsize: Try to avoid allocating miplevels.

Kenneth Graunke kenneth at whitecape.org
Mon Dec 12 20:02:45 UTC 2016


On Monday, December 12, 2016 10:14:35 AM PST Eric Anholt wrote:
> Kenneth Graunke <kenneth at whitecape.org> writes:
> 
> > A 16384x16384 RGBA8888 buffer takes 1GB of RAM.  If the driver allocates
> > mipmap levels, that increases our storage requirements to 1.5GB.  The
> > test doesn't use mipmapping, so this seems like a waste.
> >
> > Disabling mipmap filtering before allocating the texture provides a hint
> > to the driver, suggesting that it should only allocate space for the
> > base level.  Most Mesa drivers (Gallium and i965) follow this practice.
> >
> > Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> It would probably be good for coverage if the fbo-maxsize test tested
> that you could render all the way down the miptree of a maximum-sized
> FBO, but given that it doesnt, this is:
> 
> Reviewed-by: Eric Anholt <eric at anholt.net>
> 

Thanks!  I screwed up and missed applying the Reviewed-by tag, and
apparently Piglit doesn't allow non-fast-forward pushes (like Mesa),
so I can't fix it.  Sorry :(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161212/874519a5/attachment.sig>


More information about the Piglit mailing list