[Piglit] [PATCH v3 2/2] arb_transform_feedback_overflow_query: add error tests.

[Dylan Baker]

Quoting Rafael Antognolli (2016-12-13 14:51:14)
> Add tests to verify that GL_ERROR_VALUE is returned if an invalid
> index is used to begin, end or get a current query.
> 
> v2:
>     - Add test to all.py (Ilia Mirkin)
>     - Add check for ARB_transform_feedback_overflow_query extension
> v3:
>     - Skip test if some extensions are not present (Ilia Mirkin)
> 
> Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
> ---
>  tests/all.py                                       |   2 +
>  .../CMakeLists.gl.txt                              |   1 +
>  .../arb_transform_feedback_overflow_query/errors.c | 279 +++++++++++++++++++++
>  3 files changed, 282 insertions(+)
>  create mode 100644 tests/spec/arb_transform_feedback_overflow_query/errors.c
> 
> diff --git a/tests/all.py b/tests/all.py
> index 888f25f..dbfe225 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -3680,6 +3680,8 @@ with profile.test_list.group_manager(
>          grouptools.join('spec', 'arb_transform_feedback_overflow_query')) as g:
>      g(['arb_transform_feedback_overflow_query-basic'],
>        'arb_transform_feedback_overflow_query-basic', run_concurrent=False)
> +    g(['arb_transform_feedback_overflow_query-errors'],
> +      'arb_transform_feedback_overflow_query-errors', run_concurrent=False)

See my comment on the previous patch here too.

Also, I just noticed that you're setting run_concurrent to False, is there a
particular reason that these tests need to be run serially? Generally only tests
that do front buffer rendering or have CPU/GPU synchronization requirements need
to be set to run_concurrent.

Cheers,
Dylan

[snip]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161215/330f7651/attachment.sig>