[Piglit] [PATCH 00/44] Port framework to run on both python 2.7 and 3.3+

[Jose Fonseca]

On 02/02/16 22:37, Dylan Baker wrote:
> Okay, it was a pretty trivial bug, I've pushed an updated branch to
> github, I can send an updated patch too if you prefer.

No, I got it.


I've also quickly skimmed through the patch series.  I've spotted no 
problem.

Series is

Acked-by: Jose Fonseca <jfonseca at vmware.com>


>
> Dylan
>
> Quoting Jose Fonseca (2016-02-01 15:35:25)
>> Dylan,
>>
>>
>> I tried to build your branch.  With Python 2.7 for starters (just for
>> conveniency, then my plan was to build with Python 3.)
>>
>> But I get this failure, both on Windows and Linux:
>>
>> [21/3075] Generating tests/util/piglit-dispatch-gen.c,
>> tests/util/piglit-dispatch-gen.h, tests/util/piglit-util-gl-enum-gen.c
>> FAILED: cd /home/jfonseca/work/vmware/tests/piglit/build/lin64 &&
>> /usr/bin/python2.7
>> /home/jfonseca/work/vmware/tests/piglit/tests/util/gen_dispatch.py
>> --out-dir /home/jfonseca/work/vmware/tests/piglit/build/lin64/tests/util
>> Traceback (most recent call last):
>>     File
>> "/home/jfonseca/work/vmware/tests/piglit/tests/util/gen_dispatch.py",
>> line 195, in <module>
>>       main()
>>     File
>> "/home/jfonseca/work/vmware/tests/piglit/tests/util/gen_dispatch.py",
>> line 68, in main
>>       gl_registry = registry.gl.parse()
>>     File
>> "/home/jfonseca/work/vmware/tests/piglit/tests/util/../../registry/gl.py",
>> line 62, in parse
>>       return Registry(xml_registry)
>>     File
>> "/home/jfonseca/work/vmware/tests/piglit/tests/util/../../registry/gl.py",
>> line 363, in __init__
>>       self.commands.add(command)
>>     File
>> "/home/jfonseca/work/vmware/tests/piglit/tests/util/../../registry/gl.py",
>> line 220, in add
>>       key = self.__key_func(value)
>> TypeError: 'unicode' object is not callable
>>
>>
>> Jose