[Piglit] [PATCH] arb_shader_atomic_counters: fix glsl version

[Lofstedt, Marta]

Thanks for the review Tapani, remember that I don't have merge rights on Pilglit... :)

Ilia, I don't know either it would be quite easy to do the fix in glsl, but I am thinking that this looks better..

/Marta

> -----Original Message-----
> From: Piglit [mailto:piglit-bounces at lists.freedesktop.org] On Behalf Of Ilia
> Mirkin
> Sent: Wednesday, February 3, 2016 3:15 PM
> To: Palli, Tapani
> Cc: piglit at lists.freedesktop.org
> Subject: Re: [Piglit] [PATCH] arb_shader_atomic_counters: fix glsl version
> 
> I don't see anything in the extension spec which would prevent
> gl_MaxGeometryAtomicCounters from being exposed in earlier GLSL
> versions. But like you say, it also doesn't make a ton of sense... I could go
> either way on this.
> 
> On Wed, Feb 3, 2016 at 9:02 AM, Tapani Pälli <tapani.palli at intel.com> wrote:
> > Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
> >
> >
> > On 02/02/2016 12:38 PM, Marta Lofstedt wrote:
> >>
> >> From: Marta Lofstedt <marta.lofstedt at intel.com>
> >>
> >> The gl_MaxGeometryAtomicCounters does not make sense util we have
> >> geometry shaders. I.e. glsl version 150 is the limit for this tests.
> >>
> >> Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> >> ---
> >>   tests/spec/arb_shader_atomic_counters/compiler/builtins.frag | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git
> >> a/tests/spec/arb_shader_atomic_counters/compiler/builtins.frag
> >> b/tests/spec/arb_shader_atomic_counters/compiler/builtins.frag
> >> index 74f97f7..392b255 100644
> >> --- a/tests/spec/arb_shader_atomic_counters/compiler/builtins.frag
> >> +++ b/tests/spec/arb_shader_atomic_counters/compiler/builtins.frag
> >> @@ -1,13 +1,13 @@
> >>   /* [config]
> >>    * expect_result: pass
> >> - * glsl_version: 1.40
> >> + * glsl_version: 1.50
> >>    * require_extensions: GL_ARB_shader_atomic_counters
> >>    * [end config]
> >>    *
> >>    * Check that the builtin constants defined by the extension
> >>    * are present.
> >>    */
> >> -#version 140
> >> +#version 150
> >>   #extension GL_ARB_shader_atomic_counters: require
> >>     out ivec4 fcolor;
> >
> >
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/piglit
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit