[Piglit] [PATCH 04/11] framework/test/opengl.py: Add FastSkipMixin which checks extensions

Dylan Baker baker.dylan.c at gmail.com
Wed Feb 10 21:44:41 UTC 2016


Quoting Marek Olšák (2016-02-10 13:37:57)
> On Mon, Jan 4, 2016 at 7:04 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > Okay. I'm going to push the patch Jose reviewed, and I'll send out a patch
> > (and CC both of you) that adds an environment variable to turn fast skipping
> > off.
> >
> > If you could, I'd appreciate the output of wflinfo from the driver in
> > question.
> 
> The output of "wflinfo --platform gbm --api gl" is:
> 
> ATTENTION: default value of option vblank_mode overridden by environment.
> Waffle platform: gbm
> Waffle api: gl
> OpenGL vendor string: X.Org
> OpenGL renderer string: Gallium 0.4 on AMD CAPE VERDE (DRM 2.43.0, LLVM 3.9.0)
> OpenGL version string: 3.0 Mesa 11.2.0-devel (git-9ffae12)
> 
> It still happens with current master:
> 
> Exception: Unreachable
> Traceback (most recent call last):ail: 55 \/-\
>   File "/home/marek/dev/piglit/framework/test/base.py", line 204, in execute
>     self.run()
>   File "/home/marek/dev/piglit/framework/test/base.py", line 254, in run
>     self.is_skip()
>   File "/home/marek/dev/piglit/framework/test/opengl.py", line 359, in is_skip
>     if (self.__info.glsl_version is not None
>   File "/home/marek/dev/piglit/framework/core.py", line 207, in __get__
>     value = self.__func(instance)
>   File "/home/marek/dev/piglit/framework/test/opengl.py", line 255, in
> glsl_version
>     'OpenGL shading language').split()[-1][:4])
>   File "/home/marek/dev/piglit/framework/test/opengl.py", line 115, in __getline
>     raise Exception('Unreachable')
> 
> Also the exception is thrown by a lot of tests.
> 
> Thanks for any suggestions,
> 
> Marek

I have patches to waffle to add a JSON mode and make everything more
robust, but those seem to have stalled.

In the short term the environment variable "PIGLIT_NO_FAST_SKIP=1"
should disable the fast skipping and get around the issue.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160210/cdff44cf/attachment.sig>


More information about the Piglit mailing list