[Piglit] [Bug 93336] [IVB, HSW] piglit.spec.arb_program_interface_query.arb_program_interface_query-getprogramresourceiv crashes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93336

Alejandro Piñeiro (freenode IRC: apinheiro) <apinheiro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Alejandro Piñeiro (freenode IRC: apinheiro) <apinheiro at igalia.com> ---
(In reply to Alejandro Piñeiro (freenode IRC: apinheiro) from comment #3)
> (In reply to Alejandro Piñeiro (freenode IRC: apinheiro) from comment #2)
> 
> > So. I think that the way to solve this would be change the layout at the
> > test, to one using the format qualifier, as is the one required by the ARB
> > version of the extension.
> 
> Patch sent to piglit:
> https://patchwork.freedesktop.org/patch/73278/

Patch reviewed and pushed:

commit b7a65af75afb3664a1e908b09c8a39fa4490c2cc
Author: Alejandro Piñeiro <apinheiro at igalia.com>
Date:   Thu Feb 11 12:04:40 2016 +0100

    program_interface_query: use format layout qualifiers instead of size*
layout qualifiers

    From ARB_shader_image_load_store spec:

    "    (0) How does this extension differ from the similar
            EXT_shader_image_load_store?

          RESOLVED:  The functionality provided by this extension is very
similar
          to that provided by EXT_shader_image_load_stores.  There are some
          functional differences.

            * "size" layout qualifiers replaced with "format" qualifiers.

            * Image loads aren't restricted to "1x8", "1x16", "1x32", "2x32",
and
              "4x32" formats.  Instead, each supported image format has a
layout
              qualifier, and values loaded from images are converted to an
              vec4/ivec4/uvec4 representation appropriate for the image
format."

    size4x32 was valid for EXT_shader_image_load_store. That explains
    why this test works properly on proprietary NVIDIA drivers, as
    both extensions are supported.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93336
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>


Closing bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160211/410ed9e2/attachment.html>