[Piglit] [PATCH] clearbuffer: remove invalid buffer calls from drawbuffer test

[Brian Paul]

On 02/12/2016 06:36 PM, Ilia Mirkin wrote:
> Reported-by: Mark Janes <mark.a.janes at intel.com>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>   .../gl-3.0/api/clearbuffer-invalid-drawbuffer.c    | 36 ----------------------
>   1 file changed, 36 deletions(-)
>
> diff --git a/tests/spec/gl-3.0/api/clearbuffer-invalid-drawbuffer.c b/tests/spec/gl-3.0/api/clearbuffer-invalid-drawbuffer.c
> index ca0ee8f..752d749 100644
> --- a/tests/spec/gl-3.0/api/clearbuffer-invalid-drawbuffer.c
> +++ b/tests/spec/gl-3.0/api/clearbuffer-invalid-drawbuffer.c
> @@ -77,25 +77,9 @@ void piglit_init(int argc, char **argv)
>   	if (!piglit_check_gl_error(GL_INVALID_VALUE))
>   		piglit_report_result(PIGLIT_FAIL);
>
> -	glClearBufferuiv(GL_DEPTH, 1, (GLuint *) zero_i);
> -	if (!piglit_check_gl_error(GL_INVALID_VALUE))
> -		piglit_report_result(PIGLIT_FAIL);
> -
> -	glClearBufferuiv(GL_DEPTH, -1, (GLuint *) zero_i);
> -	if (!piglit_check_gl_error(GL_INVALID_VALUE))
> -		piglit_report_result(PIGLIT_FAIL);
> -
>   	if (!piglit_automatic)
>   		printf("Trying invalid drawbuffer with GL_STENCIL...\n");
>
> -	glClearBufferfv(GL_STENCIL, 1, zero_f);
> -	if (!piglit_check_gl_error(GL_INVALID_VALUE))
> -		piglit_report_result(PIGLIT_FAIL);
> -
> -	glClearBufferfv(GL_STENCIL, -1, zero_f);
> -	if (!piglit_check_gl_error(GL_INVALID_VALUE))
> -		piglit_report_result(PIGLIT_FAIL);
> -
>   	glClearBufferiv(GL_STENCIL, 1, zero_i);
>   	if (!piglit_check_gl_error(GL_INVALID_VALUE))
>   		piglit_report_result(PIGLIT_FAIL);
> @@ -104,14 +88,6 @@ void piglit_init(int argc, char **argv)
>   	if (!piglit_check_gl_error(GL_INVALID_VALUE))
>   		piglit_report_result(PIGLIT_FAIL);
>
> -	glClearBufferuiv(GL_STENCIL, 1, (GLuint *) zero_i);
> -	if (!piglit_check_gl_error(GL_INVALID_VALUE))
> -		piglit_report_result(PIGLIT_FAIL);
> -
> -	glClearBufferuiv(GL_STENCIL, -1, (GLuint *) zero_i);
> -	if (!piglit_check_gl_error(GL_INVALID_VALUE))
> -		piglit_report_result(PIGLIT_FAIL);
> -
>   	/* Page 263 (page 279 of the PDF) of the OpenGL 3.0 spec says:
>   	 *
>   	 *     "The command
> @@ -203,22 +179,10 @@ void piglit_init(int argc, char **argv)
>   	if (!piglit_check_gl_error(GL_NO_ERROR))
>   		piglit_report_result(PIGLIT_FAIL);
>
> -	glClearBufferuiv(GL_DEPTH, 0, (GLuint *) zero_i);
> -	if (!piglit_check_gl_error(GL_NO_ERROR))
> -		piglit_report_result(PIGLIT_FAIL);
> -
> -	glClearBufferfv(GL_STENCIL, 0, zero_f);
> -	if (!piglit_check_gl_error(GL_NO_ERROR))
> -		piglit_report_result(PIGLIT_FAIL);
> -
>   	glClearBufferiv(GL_STENCIL, 0, zero_i);
>   	if (!piglit_check_gl_error(GL_NO_ERROR))
>   		piglit_report_result(PIGLIT_FAIL);
>
> -	glClearBufferuiv(GL_STENCIL, 0, (GLuint *) zero_i);
> -	if (!piglit_check_gl_error(GL_NO_ERROR))
> -		piglit_report_result(PIGLIT_FAIL);
> -
>   	glClearBufferfi(GL_DEPTH_STENCIL, 0, 0.0f, 0);
>   	if (!piglit_check_gl_error(GL_NO_ERROR))
>   		piglit_report_result(PIGLIT_FAIL);
>

I'm not sure why they spec'd that GL_STENCIL can't be cleared with 
glClearBufferuiv().

In any case,  Reviewed-by: Brian Paul <brianp at vmware.com>