[Piglit] [PATCH 2/2] arb_compute_shader: Add test for dispatches with a zero size

Jordan Justen jordan.l.justen at intel.com
Tue Feb 16 16:27:41 UTC 2016


The ARB_compute_shader spec says:

  "If the work group count in any dimension is zero, no work groups
   are dispatched."

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94100
Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
---
 tests/all.py                                       |  1 +
 tests/spec/arb_compute_shader/CMakeLists.gl.txt    |  1 +
 tests/spec/arb_compute_shader/zero-dispatch-size.c | 82 ++++++++++++++++++++++
 3 files changed, 84 insertions(+)
 create mode 100644 tests/spec/arb_compute_shader/zero-dispatch-size.c

diff --git a/tests/all.py b/tests/all.py
index 1dc7f9d..848ff6f 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -4195,6 +4195,7 @@ with profile.group_manager(
     g(['arb_compute_shader-indirect-compute'], 'indirect-compute')
     g(['arb_compute_shader-local-id'], 'local-id' + '-explosion')
     g(['arb_compute_shader-render-and-compute'], 'render-and-compute')
+    g(['arb_compute_shader-zero-dispatch-size'], 'zero-dispatch-size')
 
 with profile.group_manager(
         PiglitGLTest,
diff --git a/tests/spec/arb_compute_shader/CMakeLists.gl.txt b/tests/spec/arb_compute_shader/CMakeLists.gl.txt
index 103ad2c..d7b9812 100644
--- a/tests/spec/arb_compute_shader/CMakeLists.gl.txt
+++ b/tests/spec/arb_compute_shader/CMakeLists.gl.txt
@@ -17,5 +17,6 @@ set(depends cs-ids-common.c common.c)
 piglit_add_executable (arb_compute_shader-indirect-compute indirect-compute.c ${depends})
 piglit_add_executable (arb_compute_shader-local-id local-id.c ${depends})
 piglit_add_executable (arb_compute_shader-render-and-compute render-and-compute.c ${depends})
+piglit_add_executable (arb_compute_shader-zero-dispatch-size zero-dispatch-size.c ${depends})
 
 # vim: ft=cmake:
diff --git a/tests/spec/arb_compute_shader/zero-dispatch-size.c b/tests/spec/arb_compute_shader/zero-dispatch-size.c
new file mode 100644
index 0000000..3ebf558
--- /dev/null
+++ b/tests/spec/arb_compute_shader/zero-dispatch-size.c
@@ -0,0 +1,82 @@
+/*
+ * Copyright (c) 2016 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+/** \file
+ *
+ * Tests compute dispatches with a zero workgroups
+ */
+
+#include "cs-ids-common.h"
+
+static struct piglit_gl_test_config *piglit_config;
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+	piglit_config = &config;
+	config.supports_gl_compat_version = 33;
+	config.supports_gl_core_version = 33;
+PIGLIT_GL_TEST_CONFIG_END
+
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL;
+}
+
+
+void
+piglit_init(int argc, char **argv)
+{
+	uint32_t global[3] = { 4, 8, 2 };
+	enum piglit_result result = PIGLIT_PASS;
+	int i;
+
+	cs_ids_common_init();
+	cs_ids_set_local_id_test();
+	cs_ids_set_local_size(5, 2, 5);
+
+	for (i = 0; i < 16; i++) {
+		if (i == 0)
+			cs_ids_use_direct_dispatch();
+		else if (i == 8)
+			cs_ids_use_indirect_dispatch();
+
+		cs_ids_set_global_size((i & 1) ? global[0] : 0u,
+				       (i & 2) ? global[1] : 0u,
+				       (i & 4) ? global[2] : 0u);
+
+		cs_ids_set_local_id_test();
+		result = cs_ids_run_test();
+		if (result != PIGLIT_PASS)
+			piglit_report_result(result);
+
+		cs_ids_set_global_id_test();
+		result = cs_ids_run_test();
+		if (result != PIGLIT_PASS)
+			piglit_report_result(result);
+	}
+
+	cs_ids_common_destroy();
+
+	piglit_report_result(result);
+}
-- 
2.7.0



More information about the Piglit mailing list