[Piglit] [PATCH 2/2] EGL: build the egl_chromium_sync_control test only if PIGLIT_HAS_X11

Emil Velikov emil.l.velikov at gmail.com
Tue Feb 16 23:15:11 UTC 2016


On 15 February 2016 at 21:49, Ben Widawsky <benjamin.widawsky at intel.com> wrote:
> On Fri, Feb 12, 2016 at 06:04:53PM +0100, Mircea Gherzan wrote:
>> On 12-Feb-16 1:35 AM, Ben Widawsky wrote:
>> >On Fri, Feb 12, 2016 at 12:22:49AM +0100, Mircea Gherzan wrote:
>> >>The test uses X11 headers so this guard is needed.
>> >>
>> >>Signed-off-by: Mircea Gherzan <mircea.gherzan at intel.com>
>> >
>> >Both are:
>> >Acked-by: Ben Widawsky <benjamin.widawsky at intel.com>
>>
>> Ben, can you please push these two patches? I do not have commmit rights.
>>
>> Thanks.
>>
>> --
>> Mircea
>
> Both pushed, since nobody seemed opposed. Note, I didn't actually attempt to
> build without X deps.
>
> Emil, do you have any gripes with the corresponding waffle patch?
>
Sidetracked with some family stuff. Both piglit and waffle patches
look ok. Thanks all. I'm wondering if libepoxy would need a similar
change ?

The 'gripe' is with the harcoded 'Linux you must have X" assumption
set by the standard/headers. It kind of forces us to do this
workaround.

-Emil


More information about the Piglit mailing list