[Piglit] [PATCH] counters/semantics: change the point emitted from TES that carries info

Kenneth Graunke kenneth at whitecape.org
Sun Jan 3 00:52:05 PST 2016


On Sunday, January 3, 2016 3:03:14 AM PST Ilia Mirkin wrote:
> Previously we emitted the point where x == y == 0. This was the first
> point and was always overwritten. Instead emit the x == 1, y == 0 point
> which is the last emitted in a ccw ordering.
> 
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  tests/spec/arb_shader_atomic_counters/semantics.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_shader_atomic_counters/semantics.c b/tests/spec/
arb_shader_atomic_counters/semantics.c
> index 921c0e8..931f030 100644
> --- a/tests/spec/arb_shader_atomic_counters/semantics.c
> +++ b/tests/spec/arb_shader_atomic_counters/semantics.c
> @@ -338,7 +338,7 @@ run_test_tess_evaluation(void)
>                  "               gl_in[1].gl_Position * gl_TessCoord.y +\n"
>                  "               gl_in[2].gl_Position * gl_TessCoord.z;\n"
>                  "       \n"
> -                "       if (gl_TessCoord.z == 1.0) {\n"
> +                "       if (gl_TessCoord.y == 0.0 && gl_TessCoord.x == 1.0) 
{\n"
>                  "               tecolor.x = int(atomicCounterDecrement(x));
\n"
>                  "               tecolor.y = int(atomicCounterIncrement(x));
\n"
>                  "               tecolor.z = int(atomicCounterIncrement(x));
\n"
> 

Thanks!  This makes sense.  It also fixes the test on i965.

This test was mentioned in Mesa bug 93542:
https://bugs.freedesktop.org/show_bug.cgi?id=93542
but I'm not sure if it's worth referencing.  Up to you.

Reviewed-and-tested-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20160103/950438e6/attachment.sig>


More information about the Piglit mailing list