[Piglit] [PATCH 01/16] namespace-pollution: Initial framework and test cases for namespace pollution

Ian Romanick idr at freedesktop.org
Thu Jan 7 11:40:01 PST 2016

On 01/06/2016 06:52 PM, Ilia Mirkin wrote:
> A general comment -- this doesn't check whether meta messes up
> existing bindings. Am I mistaken? i.e. nothing checks
> GL_ARRAY_BUFFER_BINDING or whatever across these various operations.
> This could always be left to later, but it does seem like a possible
> thing for meta to screw up. Irregardless, this patch is

Correct.  These tests do not check the bindings.  Those would be good
tests to have, but I think that would be a (mostly) separate test.
Perhaps it could share the do_Foo functions?

There are some other tests in
https://bugs.freedesktop.org/show_bug.cgi?id=92363#c8 that I think are
more important... I'm almost 100% certain that there are some
multicontext bugs w.r.t. meta. :(

> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>   -ilia

More information about the Piglit mailing list