[Piglit] [PATCH V2] arb_shader_image_load_store: fix syntax error in execution tests

Timothy Arceri timothy.arceri at collabora.com
Wed Jan 20 14:32:27 PST 2016


On Wed, 2016-01-20 at 03:42 -0500, Ilia Mirkin wrote:
> On Tue, Jan 19, 2016 at 9:21 PM, Timothy Arceri
> <timothy.arceri at collabora.com> wrote:
> > @@ -98,7 +98,7 @@ header_hunk(const struct grid_info grid)
> >                   "#define H %d\n"
> >                   "#define N %d\n"
> >                   "#define GRID_T %s\n"
> > -                 "#define RET_IMAGE_T layout(%s) %s2D\n",
> > +                 "#define RET_IMAGE_UNIFORM_T uniform layout(%s)
> > %s2D\n",
> >                   grid.size.x, grid.size.y, product(grid.size),
> >                   image_vector_type_name(grid.format),
> >                   grid.format->name, image_type_name(grid.format));
> 
> Doesn't this do the exact opposite of what you wanted? I thought you
> wanted
> 
> layout(foo) uniform bla;
> 
> While this change leaves uniform before the layout.

Correct. I missed this in testing as for some reason this only gets run
on IVB and HSW. Fix sent.



> 
>   -ilia
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list