[Piglit] [PATCH 17/21] arb_internalformat_query2: test for TEXTURE_COMPRESSED_BLOCK_<X>

Alejandro Piñeiro apinheiro at igalia.com
Fri Jan 22 08:06:04 PST 2016


This test add a check for the following pnames:
  * TEXTURE_COMPRESSED_BLOCK_WIDTH
  * TEXTURE_COMPRESSED_BLOCK_HEIGHT
  * TEXTURE_COMPRESSED_BLOCK_SIZE

On all those three, query2 spec says the following:
"If the internal format is not compressed, or the resource is not
 supported, 0 is returned."

We could have classified the existing internalformats on
compressed/non-compressed (similar to color-format/non-color-format
for COLOR_ENCONDING), but that seems pointless taking into account
that we already have TEXTURE_COMPRESSED to query if a internalformat
is compressed.

So this test queries TEXTURE_COMPRESSED and INTERNALFORMAT_SUPPORTED,
and if any of them is false, checks that the returned value for any of
those three pnames is zero.

Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass.
---
 tests/all.py                                       |   1 +
 .../arb_internalformat_query2/CMakeLists.gl.txt    |   2 +
 .../texture-compressed-block.c                     | 202 +++++++++++++++++++++
 3 files changed, 205 insertions(+)
 create mode 100644 tests/spec/arb_internalformat_query2/texture-compressed-block.c

diff --git a/tests/all.py b/tests/all.py
index 8e3ff6f..d672ac8 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -3644,6 +3644,7 @@ with profile.group_manager(
     g(['arb_internalformat_query2-image-format-compatibility-type'], 'IMAGE_FORMAT_COMPATIBILITY_TYPE pname checks')
     g(['arb_internalformat_query2-max-dimensions'], 'Max dimensions related pname checks')
     g(['arb_internalformat_query2-color-encoding'], 'COLOR_ENCODING pname check')
+    g(['arb_internalformat_query2-texture-compressed-block'], 'All TEXTURE_COMPRESSED_BLOCK_<X> pname checks')
 
 with profile.group_manager(
         PiglitGLTest, grouptools.join('spec', 'arb_map_buffer_range')) as g:
diff --git a/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt b/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
index d56e002..5af4b2e 100644
--- a/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
+++ b/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
@@ -16,4 +16,6 @@ piglit_add_executable (arb_internalformat_query2-internalformat-type-checks inte
 piglit_add_executable (arb_internalformat_query2-image-format-compatibility-type image-format-compatibility-type.c common.c)
 piglit_add_executable (arb_internalformat_query2-max-dimensions max-dimensions.c common.c)
 piglit_add_executable (arb_internalformat_query2-color-encoding color-encoding.c common.c)
+piglit_add_executable (arb_internalformat_query2-texture-compressed-block texture-compressed-block.c common.c)
+
 # vim: ft=cmake:
diff --git a/tests/spec/arb_internalformat_query2/texture-compressed-block.c b/tests/spec/arb_internalformat_query2/texture-compressed-block.c
new file mode 100644
index 0000000..3bc4f95
--- /dev/null
+++ b/tests/spec/arb_internalformat_query2/texture-compressed-block.c
@@ -0,0 +1,202 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file texture-compressed-block.c
+ *
+ * Verify conditions defined on the spec for the following pnames:
+ *  * TEXTURE_COMPRESSED_BLOCK_WIDTH
+ *  * TEXTURE_COMPRESSED_BLOCK_HEIGHT
+ *  * TEXTURE_COMPRESSED_BLOCK_SIZE
+ *
+ * In all those three the spec says :
+ *
+ * "If the internal format is not compressed, or the resource is not
+ *  supported, 0 is returned."
+ *
+ * One could guess which internalformats are compressed, but
+ * TEXTURE_COMPRESSED is already there to know that.
+ *
+ * So this test just verifies that if TEXTURE_COMPRESSED or
+ * INTERNALFORMAT_SUPPORTED are false, all those pnames should return
+ * 0.
+ *
+ * In that sense, this test is generic-pname-checks on those pnames,
+ * plus a TEXTURE_COMPRESSED check.
+ *
+ */
+
+#include "common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_compat_version = 10;
+	config.window_visual = PIGLIT_GL_VISUAL_RGB;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL;
+}
+
+static const GLenum pnames[] = {
+        GL_TEXTURE_COMPRESSED_BLOCK_WIDTH,
+        GL_TEXTURE_COMPRESSED_BLOCK_HEIGHT,
+        GL_TEXTURE_COMPRESSED_BLOCK_SIZE,
+};
+
+/* As with test_data_check_supported, @data is only used to know if we
+ * are checking the 32 or the 64-bit query. @data content should not
+ * be modified */
+static bool
+test_data_check_compressed(test_data *data,
+                           const GLenum target,
+                           const GLenum internalformat)
+{
+        bool result;
+        test_data *local_data = test_data_new(test_data_get_testing64(data), 1);
+
+        test_data_execute(local_data, target, internalformat,
+                          GL_TEXTURE_COMPRESSED);
+
+        if (!piglit_check_gl_error(GL_NO_ERROR))
+                result = false;
+        else
+                result = test_data_value_at_index(local_data, 0) == GL_TRUE;
+
+        test_data_clear(&local_data);
+
+        return result;
+}
+
+/* try_local could be implemented as try_basic (at common.c) with
+ * @possible_values==NULL, and testing that if TEXTURE_COMPRESSED is
+ * false, it should returns zero. Candidate to be refactored */
+bool
+try_local(const GLenum *targets, unsigned num_targets,
+          const GLenum *internalformats, unsigned num_internalformats,
+          const GLenum pname,
+          test_data *data)
+{
+        bool pass = true;
+        unsigned i;
+        unsigned j;
+
+	for (i = 0; i < num_targets; i++) {
+                for (j = 0; j < num_internalformats; j++) {
+                        bool error_test;
+                        bool value_test = true;
+                        bool supported;
+                        bool compressed;
+
+                        supported = check_query2_dependencies(pname, targets[i])
+                                && test_data_check_supported(data, targets[i],
+                                                             internalformats[j]);
+
+                        compressed = test_data_check_compressed(data, targets[i],
+                                                                internalformats[j]);
+
+                        test_data_execute(data, targets[i], internalformats[j],
+                                          pname);
+
+                        /* If it is supported and compressed, we don't
+                         * have a way to verify at this point that the
+                         * returned value is correct */
+                        if (supported && compressed)
+                                continue;
+
+                        error_test =
+                                piglit_check_gl_error(GL_NO_ERROR);
+                        /*
+                         * From spec:
+                         * "If the internal format is not compressed,
+                         *  or the resource is not supported, 0 is
+                         *  returned."
+                         */
+                        if (!supported || !compressed)
+                                value_test = test_data_is_unsupported_response(data, pname);
+
+                        if (error_test && value_test)
+                                continue;
+
+                        /* If we are here, the test is failing */
+                        print_failing_case(targets[i], internalformats[j],
+                                           pname, data);
+
+                        if (!supported && !value_test)
+                                fprintf(stderr,"\tInternalformat is not supported, but returned value is not zero\n");
+
+                        if (!compressed && !value_test)
+                                fprintf(stderr,"\tInternalformat is not compressed, but returned value is not zero\n");
+
+                        pass = false;
+                }
+        }
+
+	return pass;
+}
+
+static bool
+check_texture_compressed_block(const GLenum *pnames, unsigned num_pnames)
+{
+        bool check_pass = true;
+        test_data *data = test_data_new(0, 1);
+        unsigned i;
+        int testing64;
+
+        for (i = 0; i < num_pnames; i++) {
+                bool pass = true;
+
+                for (testing64 = 0; testing64 <= 1; testing64++) {
+                        test_data_set_testing64(data, testing64);
+                        pass = try_local(valid_targets, ARRAY_SIZE(valid_targets),
+                                         valid_internalformats, ARRAY_SIZE(valid_internalformats),
+                                         pnames[i], data)
+                                && pass;
+                }
+
+                piglit_report_subtest_result(pass ? PIGLIT_PASS : PIGLIT_FAIL,
+                                             "%s", piglit_get_gl_enum_name(pnames[i]));
+
+                check_pass = check_pass && pass;
+        }
+
+        test_data_clear(&data);
+
+        return check_pass;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+        bool pass = true;
+
+        piglit_require_extension("GL_ARB_internalformat_query2");
+
+        pass = check_texture_compressed_block(pnames, ARRAY_SIZE(pnames))
+                && pass;
+
+        piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
-- 
2.1.4



More information about the Piglit mailing list