[Piglit] [PATCH 4/5] generators/gen_vs_in_fp64: Adds support to specify the GL type in the VBO

Andres Gomez agomez at igalia.com
Fri Jul 1 14:00:45 UTC 2016

On Thu, 2016-06-30 at 11:22 -0700, Dylan Baker wrote:
> Quoting Andres Gomez (2016-06-30 02:30:31)


> > I think you are quite right on this.
> > 
> > In any case, this patch is not adding more tests than the ones that
> > are
> > already there before it. The next patch in the series adds some
> > more
> > tests, though.
> > 
> > I think I can reduce a lot the amount of tests used to check the
> > correct implementation of GL_ARB_vertex_attrib_64bit since it is
> > true
> > that, probably, although all are different, many can be considered
> > redundant on the functionality checked.
> > 
> > WDYT about landing this series as is and I send a follow up patch
> > to
> > reduce the amount of tests? Or you would rather change already this
> > series to include the reduction too?
> I'm okay with following up with a reduction in the tests.

May I have, then, a R-b from you at least for the patches 4 and 5 of
this series?

> One of the other things I thought about yesterday, is maybe a good
> compromise would be to a add a filter rule to quick.py that reduces
> the
> number of tests, but let the generator create all of the tests, that
> gives the ability to get a comprehensive run, but it also allows the
> normal testing process to still be relatively quick.

Sounds reasonable.




More information about the Piglit mailing list