[Piglit] [PATCH] ext_image_dma_buf: Fix memory leak.

Chad Versace chad.versace at intel.com
Thu Jul 7 19:16:15 UTC 2016


On Fri 01 Jul 2016, Vinson Lee wrote:
> Fix Coverity resource leak defect.
> 
> CID: 1313530
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/ext_image_dma_buf_import/transcode-nv12-as-r8-gr88.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/spec/ext_image_dma_buf_import/transcode-nv12-as-r8-gr88.c b/tests/spec/ext_image_dma_buf_import/transcode-nv12-as-r8-gr88.c
> index 1e5485556111..b172255732cf 100644
> --- a/tests/spec/ext_image_dma_buf_import/transcode-nv12-as-r8-gr88.c
> +++ b/tests/spec/ext_image_dma_buf_import/transcode-nv12-as-r8-gr88.c
> @@ -294,8 +294,10 @@ piglit_display(void)
>  	piglit_tolerance[2] = 0.05;
>  	if (!piglit_probe_image_rgba(0, 0, piglit_width, piglit_height,
>  				     ref_rgba_image)) {
> +		free(ref_rgba_image);
>  		return PIGLIT_FAIL;
>  	}
>  
> +	free(ref_rgba_image);
>  	return PIGLIT_PASS;

Reviewed-by: Chad Versace <chad.versace at intel.com>
And pushed.

There are two calls to piglit_report_result() that also trigger the
leak. Those should be fixed too.


More information about the Piglit mailing list