[Piglit] [PATCH] copy-pixels: disable texture state before copying

Brian Paul brianp at vmware.com
Fri Jul 15 19:12:19 UTC 2016


On 07/15/2016 12:29 PM, Ilia Mirkin wrote:
> The intent was to copy the texture around, not to test the texture
> combining logic. (A separate test should probably be done with that
> enabled.)

I agree with that.

Reviewed-by: Brian Paul <brianp at vmware.com>

>
> Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D96943&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=S1RTKZDw5I-Sgtu75pu6lEx65o6_l4sbJnNMv8zVgJA&s=96yrBR8VMZpMELVji773WNXcadqMM3sjVR16uOVlnvI&e=
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>   tests/general/copy-pixels.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/general/copy-pixels.c b/tests/general/copy-pixels.c
> index cff1cb6..a45d821 100644
> --- a/tests/general/copy-pixels.c
> +++ b/tests/general/copy-pixels.c
> @@ -61,6 +61,8 @@ test_color_copypix(int x, int y)
>
>   	piglit_draw_rect_tex(0, 0, IMAGE_WIDTH, IMAGE_HEIGHT, 0, 0, 1, 1);
>
> +	glDisable(GL_TEXTURE_2D);
> +
>   	glRasterPos2i(x, y);
>   	glCopyPixels(0, 0, IMAGE_WIDTH, IMAGE_HEIGHT, GL_COLOR);
>   	pass = piglit_probe_image_color(x, y, IMAGE_WIDTH, IMAGE_HEIGHT,
>



More information about the Piglit mailing list