[Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v2)

Adam Jackson ajax at redhat.com
Fri Jul 22 17:20:57 UTC 2016

On Fri, 2016-07-22 at 17:00 +0100, Emil Velikov wrote:

> > +       if (queryDisplayAttrib(EGL_NO_DISPLAY, EGL_DEVICE_EXT,
> > +                              (EGLAttrib *)&device) == EGL_TRUE) {
> Don't see the spec mentioning this, but I would make perfect sense.
> > +               printf("Display query succeeded before EGL initialized\n");
> s/before EGL initialized/with EGL_NO_DISPLAY/ ?

I mean, either is descriptive, but "doing this before eglInitialize" is
the thing I'm attempting to cover here. I'll move this down between
GetDisplay and Initialize, in order to provoke...

> This one isn't covered in the spec either.

... the documented failure mode from the spec:

    On failure, EGL_FALSE is returned.  An EGL_NOT_INITIALIZED error
    is generated if EGL is not initialized for <dpy>.  An
    EGL_BAD_ATTRIBUTE error is generated if <name> is not a valid

> Use piglit_check_egl_error over the direct eglGetError calls ?

Hah, missed that one, had only managed to see tests/egl/egl-util.c and
not tests/util/piglit-util-egl.c.

- ajax

More information about the Piglit mailing list