[Piglit] [PATCH 7/7] khr_texture_compression_astc: Add test case for sliced 3d astc textures

[Anuj Phogat]

On Fri, Jul 22, 2016 at 2:06 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Fri, Jul 22, 2016 at 5:01 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> V2:  Loosen up the tolerence for sRGB tests. This will allow testing sRGB
>>      formats which have known precision issues in astcenc in void extent
>>      blocks. See khronos bug#11294 for details.
>>      Run each subtest separately in all.py
>>
>> Cc: Nanley Chery <nanley.g.chery at intel.com>
>> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
>> Acked-by: Ben Widawsky <ben at bwidawsk.net>
>> ---
>> Patch is trimmed to keep the size under limit.
>> See full patch at: https://github.com/aphogat/piglit.git, branch: review
>>
>>  tests/all.py                                       |   5 +
>>  .../khr_texture_compression_astc/CMakeLists.gl.txt |   1 +
>>  .../CMakeLists.gles3.txt                           |   1 +
>>
>> diff --git a/tests/all.py b/tests/all.py
>> index e2998d0..063453d 100644
>> --- a/tests/all.py
>> +++ b/tests/all.py
>> @@ -4360,6 +4360,11 @@ with profile.group_manager(
>>             'miptree-gl {}'.format(subtest))
>>          g(['khr_compressed_astc-miptree_gles2', '-subtest', subtest],
>>             'miptree-gles {}'.format(subtest))
>> +    for subtest in ('hdr', 'ldr', 'srgb'):
>
> Did you mean to include srgb-fp here too?
>
No. I left it out intentionally given astc sliced 3d use the same 2D astc
blocks which are tested in non-sliced version. If we pass srgb-fp in non-sliced
miptree test, I don't think there'll be a case that srgb-fp will be broken for
sliced-3d. I'm not too opposed to adding it though.

>> +        g(['khr_compressed_astc-sliced-3d-miptree_gl', '-subtest', subtest],
>> +           'sliced-3d-miptree-gl {}'.format(subtest))
>> +        g(['khr_compressed_astc-sliced-3d-miptree_gles3', '-subtest', subtest],
>> +           'sliced-3d-miptree-gles {}'.format(subtest))
>>
>>  with profile.group_manager(
>>           PiglitGLTest,