[Piglit] [PATCH] arb_separate_shader_object: Check piglit_link_check_status result.

Tapani Pälli tapani.palli at intel.com
Tue Jul 26 11:04:27 UTC 2016


Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 07/02/2016 01:38 AM, Vinson Lee wrote:
> Fix Coverity unchecked return value defect.
>
> CID: 1351103
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_separate_shader_objects/uniform-namespace.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_separate_shader_objects/uniform-namespace.c b/tests/spec/arb_separate_shader_objects/uniform-namespace.c
> index 2c8cd988de30..a62fdaa4f5d0 100644
> --- a/tests/spec/arb_separate_shader_objects/uniform-namespace.c
> +++ b/tests/spec/arb_separate_shader_objects/uniform-namespace.c
> @@ -96,7 +96,9 @@ generate_program(const char *code_template, unsigned glsl_version,
>  				      (const GLchar * const*) &code);
>  	free(code);
>
> -	piglit_link_check_status(prog);
> +	if (!piglit_link_check_status(prog)) {
> +		piglit_report_result(PIGLIT_FAIL);
> +	}
>
>  	*uniform_loc = glGetUniformLocation(prog, "a");
>
>


More information about the Piglit mailing list