[Piglit] [PATCH 8/8] EGL_EXT_image_dma_buf_import/refcount: New test for GEM handle bug.

Eric Anholt eric at anholt.net
Wed Jul 27 19:51:05 UTC 2016


Dylan Baker <dylan at pnwbakers.com> writes:

> Quoting Eric Anholt (2016-07-25 17:43:44)
>> Drivers can miss the need to refcount their GEM handles, and the
>> destroy of the image/texture pair for tex2 will result in tex1 no
>> longer being usable.
>> 
>> This fails to piglit_report_result(PIGLIT_FAIL) on vc4 (which is
>> missing the handle code), because tex1's shadow tiled temporary
>> already has the texture contents in it when the shadow linear->tiled
>> blit fails, but the driver does make a noisy warning on stderr.  On
>> intel, if you drop the global name lookup in libdrm, the driver
>> exit()s due to the -EINVAL from the draw call.
>> ---
>>  .../ext_image_dma_buf_import/CMakeLists.gles2.txt  |   1 +
>>  tests/spec/ext_image_dma_buf_import/refcount.c     | 134 +++++++++++++++++++++
>>  .../spec/ext_image_dma_buf_import/sample_common.c  |   6 +-
>>  .../spec/ext_image_dma_buf_import/sample_common.h  |   2 +-
>>  4 files changed, 139 insertions(+), 4 deletions(-)
>>  create mode 100644 tests/spec/ext_image_dma_buf_import/refcount.c

> Should this be added to all.py?

Thanks, not sure where that hunk went.  Amended in:

@@ -3040,6 +3040,7 @@ with profile.group_manager(
       run_concurrent=False)
     g(['ext_image_dma_buf_import-intel_external_sampler_with_dma_only'],
       run_concurrent=False)
+    g(['ext_image_dma_buf_import-refcount'])
     g(['ext_image_dma_buf_import-sample_rgb', '-fmt=AR24'],
       'ext_image_dma_buf_import-sample_argb8888', run_concurrent=False)
     g(['ext_image_dma_buf_import-sample_rgb', '-fmt=XR24', '-alpha-one'],
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160727/4c99e4e8/attachment.sig>


More information about the Piglit mailing list