[Piglit] [PATCH] shader_runner: Use %u in "probe atomic counter" scanf calls.
jordan.l.justen at intel.com
Wed Jun 1 06:03:58 UTC 2016
On 2016-05-31 23:00:02, Ilia Mirkin wrote:
> On Wed, Jun 1, 2016 at 1:49 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > On Wednesday, June 1, 2016 1:34:42 AM PDT Ilia Mirkin wrote:
> >> Because strtol() truncates the the maximum value of "long", as does
> >> scanf apparently. This will make it impossible to test that a counter
> >> == -1 though, right?
> > Yes, I suppose it would. But you can always do == 4294967295 instead,
> > and that seems pretty reasonable (if a bit inconvenient) considering
> > the GLSL type is "atomic_uint"...
> Fair enough. For ssbo I made it read 0xfoo for those. And there's already a
> atomic counter 1 == 4294966784
And another bug as well:
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
> So what you're doing seems reasonable.
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Piglit mailing list
> Piglit at lists.freedesktop.org
More information about the Piglit