[Piglit] [PATCH 00/20] Windows fixes

Brian Paul brianp at vmware.com
Thu Jun 2 00:10:30 UTC 2016

On 06/01/2016 05:50 PM, Dylan Baker wrote:
> I'm tired of breaking piglit on windows. This series add appveyor (and
> travis too, why not get free Linux testing while we're at it?) support
> to piglit for the python framework (it doesn't cover the generators at
> the moment), and fixes unittests and code to work on windows, mostly
> unittests because I'm sloppy with them, but hey.
> The final patch actually does fix a real bug, which is the known fcntl
> issue. It's kind of a hack, since it only hides the error until a windows
> user tries to use the monitoring code. Since to my knowledge there is no
> one on windows using the monitoring module it gets everybody up and
> running again without breaking the monitoring users on POSIX systems.
> This is available at my github:
> https://github.com/dcbaker/piglit wip/appveyor-v2

I don't really grok all this code but it sounds fine to me.

In patch 3/20 there's a "acceel" typo in the commit msg.

FWIW, for the series, Acked-by: Brian Paul <brianp at vmware.com>

Thanks for doing this!


More information about the Piglit mailing list