[Piglit] [PATCH 0/6] make gen_vs_in_fp64 run faster

Dylan Baker dylan at pnwbakers.com
Fri Jun 10 16:31:00 UTC 2016


Quoting Martin Peres (2016-06-10 03:24:51)
> On 09/06/16 19:50, Dylan Baker wrote:
> > Quoting Andres Gomez (2016-06-09 06:45:49)
> >> Nice optimizations, Dylan.
> >>
> >> I'm quite impressed/surprised on the gain through avoiding the
> >> inheritance/include mechanisms in the mako templates.
> >>
> >> This series is:
> >>
> >> Reviewed-by: Andres Gomez <agomez at igalia.com>
> >>
> >> Andres
> >
> > I was definitely surprised too, I assumed glancing over the code that
> > calling list on the generators was the big bottleneck.
> >
> > Thanks for your review.
> >
> > Dylan
> >
> 
> I really recommend SnakeViz for debugging this kind of issues, it is 
> really doing a nice job :)
> https://jiffyclub.github.io/snakeviz/

Thanks Martin, that looks really useful. Reading cProfile reports
manually is a bit of a pain, and this looks much nicer.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160610/16ee3547/attachment.sig>


More information about the Piglit mailing list