[Piglit] [PATCH 0/2] Make gen_vs_in_fp64 even faster

Dylan Baker dylan at pnwbakers.com
Fri Jun 10 23:42:25 UTC 2016

1:10 is still a long time for a generator to be running, and Martin
mentioned an extremely useful tool (snakeviz) for looking at python's
cProfile output. With that I realized that almost all of our time was
being spent in two functions, that were extracting type information from

I've had this plan to add additional helpers for generator writers for
representing GLSL type information, and this seemed like the right time
to add them.

Using these new representation's I've managed to get the generator
runtime down to about 30 seconds on my machine (less than half what it
ran before). I think that's a pretty impressive gain.

Andres, I saw your series that extends this generator. Do you think it's
better to consider landing this first and rebase your series ontop of
this, or land yours first and rebase this series?

Dylan Baker (2):
  generators/modules: Add GLSL types representations
  generators/gen_vs_in_fp64: Use modules.types

 generated_tests/gen_vs_in_fp64.py                  |  75 +++-----
 generated_tests/modules/types.py                   | 199 +++++++++++++++++++++
 .../gen_vs_in_fp64/columns.shader_test.mako        |  40 ++---
 .../gen_vs_in_fp64/regular.shader_test.mako        |  40 ++---
 unittests/generators/test_types.py                 |  79 ++++++++
 5 files changed, 326 insertions(+), 107 deletions(-)
 create mode 100644 generated_tests/modules/types.py
 create mode 100644 unittests/generators/test_types.py


More information about the Piglit mailing list