[Piglit] [PATCH 0/2] Make gen_vs_in_fp64 even faster
dylan at pnwbakers.com
Mon Jun 13 18:45:47 UTC 2016
Quoting Andres Gomez (2016-06-13 09:32:17)
> On Fri, 2016-06-10 at 16:42 -0700, Dylan Baker wrote:
> > I've had this plan to add additional helpers for generator writers
> > for
> > representing GLSL type information, and this seemed like the right
> > time
> > to add them.
> This looks very good. I'm also repeating some value arrays for testing
> each type and, also, several conversion functions from hex to actual
> values so maybe it would be worth to think also about adding this into
> a module.
> > Andres, I saw your series that extends this generator. Do you think
> > it's
> > better to consider landing this first and rebase your series ontop of
> > this, or land yours first and rebase this series?
> Let's land this first and I will rework my series. In any case, I will
> split the biggest patch as for your comments there.
I've changed to use 1 instead of None, and pushed to master. Thanks
again for your review.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
More information about the Piglit