[Piglit] [PATCH 0/5] More additional tests for ARB_vertex_attrib_64bit extension (v2)

Andres Gomez agomez at igalia.com
Mon Jun 27 15:42:30 UTC 2016


Hi,

this series is still unreviewed.

I'd welcome some help to get this into piglit with guarantees that the
changes are OK. Dylan, could you give it a look? :)

If there is nothing new by the end of this week, I will assume that all
is OK and will proceed to land the series.

On Wed, 2016-06-15 at 00:36 +0300, Andres Gomez wrote:
> The main difference in this second version is that the original patch
> 3/4 has been split in 2. The reason to have it together in the first
> version was to avoid a regression due to failures when running the
> patches when only the piglit-vbo changes would have been applied.
> 
> This new version adds the minimal changes in the patch 3/5 to prevent
> those failures while the rest of the changes in the generator have
> been moved to patch 4/5.
> 
> ---
> 
> This series provides some more additional tests for the
> ARB_vertex_attrib_64bit extension:
> 
> https://www.opengl.org/registry/specs/ARB/vertex_attrib_64bit.txt
> 
> The general aim of this series is to add support in the shader_runner
> to pass byte and short sized values/types to the vertex shader
> inputs.
> 
> With this support, the double vertex inputs generator has been
> extended to create tests that use byte and short sized types.
> 
> In addition, the series provide a fix for passing exact hex patterns
> values for int.
> 
> Andres Gomez (5):
>   util: Wrapper to load exact hex patterns for ints
>   util/gl: Wrapper to load hex values for half floats
>   util: Add u/byte, u/short and half support to [vertex data]
>   generators/gen_vs_in_fp64: Adds support to specify the GL type in
> the
>     VBO
>   generators/gen_vs_in_fp64: Adds u/byte and u/short tests
> 
>  generated_tests/gen_vs_in_fp64.py                  | 297
> +++++++++++++++---
>  .../gen_vs_in_fp64/columns.shader_test.mako        |   4 +-
>  .../gen_vs_in_fp64/regular.shader_test.mako        |  15 +-
>  tests/shaders/shader_runner.c                      |   2 +-
>  tests/util/piglit-dispatch.h                       |   1 +
>  tests/util/piglit-util-gl.h                        |  27 ++
>  tests/util/piglit-util.h                           |  24 ++
>  tests/util/piglit-vbo.cpp                          | 342
> +++++++++++++++------
>  8 files changed, 557 insertions(+), 155 deletions(-)
> 
-- 

Br,

Andres


More information about the Piglit mailing list