[Piglit] [PATCH 3/9] GLX_OML_sync_control: remove '#if defined(GLX_MESA_swap_control)' guards

Emil Velikov emil.l.velikov at gmail.com
Mon Jun 27 16:52:42 UTC 2016

From: Emil Velikov <emil.velikov at collabora.com>

Analogous to previous commit - we don't want the test to differ between
builds. This could lead to the test silently skipping when built against
old headers, _regardless_ if at runtime the extension is supported or

With this commit no GLX test in piglit (barring glean) relies on this
broken behaviour. Checked with the following:

$ git grep "defined.*\<GLX_"
$ git grep "ifdef.*\<GLX_"

Only local definitions can be seen with the inverse query
$ git grep "ifndef.*\<GLX_"

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
 tests/spec/glx_oml_sync_control/swapbuffersmsc-return.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/spec/glx_oml_sync_control/swapbuffersmsc-return.c b/tests/spec/glx_oml_sync_control/swapbuffersmsc-return.c
index 9dfec79..a4a1774 100644
--- a/tests/spec/glx_oml_sync_control/swapbuffersmsc-return.c
+++ b/tests/spec/glx_oml_sync_control/swapbuffersmsc-return.c
@@ -54,7 +54,6 @@ draw(Display *dpy)
 	piglit_set_timeout(5, PIGLIT_FAIL);
 	if (swap_interval != -1) {
-#if defined(GLX_MESA_swap_control)
 		printf("Testing with swap interval %d\n", swap_interval);
@@ -64,12 +63,6 @@ draw(Display *dpy)
 			glXGetProcAddressARB((const GLubyte *)
-		fprintf(stderr,
-			"Testing swap interval %d requires building with GLX_MESA_swap_control\n",
-			swap_interval);
-		piglit_report_result(PIGLIT_SKIP);
 	} else {
 		printf("Testing with default swap interval\n");

More information about the Piglit mailing list