[Piglit] [PATCH 6/9] util/gl: remove '#if defined(GL_SYMBOL)' guards
imirkin at alum.mit.edu
Tue Jun 28 16:02:57 UTC 2016
On Tue, Jun 28, 2016 at 11:50 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 28 June 2016 at 16:10, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> On Tue, Jun 28, 2016 at 10:45 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> On 27 June 2016 at 18:04, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>>> Don't we build against local GL headers? So we pretty much control
>>>> what's available and what's not. i.e. do we need those ifdefs?
>>> No we don't have/build against local GL headers. We use the system ones.
>> Hmmm... so then why is it OK to delete all the various other guards
>> but not these ones?
> Afaict the tendency is to add the guards/defines only if needed. With
> the other guards/symbols existing in the mesa/amd/nvidia headers for
> at least 2-3 years I've just dropped them. While these were trivial
> enough to keep.
> While I am leaning towards dropping the local defines, I don't mind either way.
I'd rather drop these too then. They appear to be in both desktop GL
and GL ES. I suspect all vendors should have these. If not, we can
More information about the Piglit