[Piglit] [PATCH 6/7] texsubimage: Remove unnecessary clear

Topi Pohjolainen topi.pohjolainen at intel.com
Tue Mar 1 10:13:27 UTC 2016


Not really needed as all the inspected pixels are overwritten
after the clear but before getting read back.

Allows one to reproduce 91926 on SKL with 100% probability:

texsubimage pbo manual GL_TEXTURE_2D GL_RGB8 6 10 0 94 53 0 -auto -fbo
6,10,0: test = 40,12,0,255 ref = 12,0,40,255 (comparing 8 bits)
texsubimage failed
  target: GL_TEXTURE_2D
  internal format: GL_RGB8
  region: 6, 10  94 x 53
PIGLIT: {"result": "fail" }

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91926
Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
---
 tests/texturing/texsubimage.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/texturing/texsubimage.c b/tests/texturing/texsubimage.c
index a0d811f..0d4bcab 100644
--- a/tests/texturing/texsubimage.c
+++ b/tests/texturing/texsubimage.c
@@ -376,7 +376,6 @@ test_region(GLuint pbo, GLenum target, GLenum internal_format,
 		glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0);
 
 	/* draw test image */
-	glClear(GL_COLOR_BUFFER_BIT);
 	draw_and_read_texture(w, h, d, test_img);
 
 	glDeleteTextures(1, &tex);
-- 
2.5.0



More information about the Piglit mailing list