[Piglit] [PATCH 1/8] arb_gpu_shader_fp64: Adds GS preprocessor define test

[Andres Gomez]

On Thu, 2016-03-17 at 10:28 +1000, Dave Airlie wrote:
> On 16 March 2016 at 01:50, Andres Gomez <agomez at igalia.com> wrote:
> > Signed-off-by: Andres Gomez <agomez at igalia.com>
> 
> For completeness should we have tess and compute version of this test?

In these series of additional tests we have focused in VS, GS and FS
since most of the existing piglit tests are only considering those
stages.

In addition, we were creating the tests having in mind the status of
development of the missing pieces of the i965 backend for this
extension. Covering the VS, GS and FS stages suffices to test the two
code paths used in the backend; scalar and vectorial. Hence,
theoretically, and just for the case of i965, TESS and CS are also
covered with the current tests.

In any case, creating additional TESS and CS tests would be interesting,
from an implementation agnostic point of view.

> This test is
> 
> Reviewed-by: Dave Airlie <airlied at redhat.com>

Thanks for the review!

> 
> Dave.
> 
> > ---
> >  .../spec/arb_gpu_shader_fp64/preprocessor/define.geom | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >  create mode 100644 tests/spec/arb_gpu_shader_fp64/preprocessor/define.geom
> >
> > diff --git a/tests/spec/arb_gpu_shader_fp64/preprocessor/define.geom b/tests/spec/arb_gpu_shader_fp64/preprocessor/define.geom
> > new file mode 100644
> > index 0000000..85dd9bf
> > --- /dev/null
> > +++ b/tests/spec/arb_gpu_shader_fp64/preprocessor/define.geom
> > @@ -0,0 +1,19 @@
> > +// [config]
> > +// expect_result: pass
> > +// glsl_version: 1.50
> > +// require_extensions: GL_ARB_gpu_shader_fp64
> > +// [end config]
> > +
> > +#version 150
> > +#extension GL_ARB_gpu_shader_fp64: require
> > +
> > +#if !defined GL_ARB_gpu_shader_fp64
> > +#  error GL_ARB_gpu_shader_fp64 is not defined
> > +#elif GL_ARB_gpu_shader_fp64 != 1
> > +#  error GL_ARB_gpu_shader_fp64 is not equal to 1
> > +#endif
> > +
> > +/* Some compilers generate spurious errors if a shader does not contain
> > + * any code or declarations.
> > + */
> > +int foo(void) { return 1; }
> > --
> > 2.1.0
> >
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/piglit
> 

-- 
Br,

Andres
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160317/673f46c0/attachment.sig>