[Piglit] [PATCH] tests/spec/glsl-1.20: added #version 120 to tests

Dylan Baker baker.dylan.c at gmail.com
Fri Mar 25 19:28:09 UTC 2016


Quoting Lars Hamre (2016-03-24 12:13:01)
> From: Lars <chemecse at gmail.com>
> 
> Adds the #version directive to glsl 1.20 tests so they don't
> default to being glsl 1.10.
> 
> NOTE: this is my first time contributing to piglit, so someone will
>       need to commit these changes after the review process.
> 
> Signed-off-by: Lars Hamre <chemecse at gmail.com>
> 
> ---
>  .../glsl-1.20/compiler/literals/valid-float-exponent-with-suffix.vert   | 2 ++
>  .../spec/glsl-1.20/compiler/literals/valid-float-suffix-capital-f.vert  | 2 ++
>  tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-f.vert        | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/tests/spec/glsl-1.20/compiler/literals/valid-float-exponent-with-suffix.vert b/tests/spec/glsl-1.20/compiler/literals/valid-float-exponent-with-suffix.vert
> index d303036..577f739 100644
> --- a/tests/spec/glsl-1.20/compiler/literals/valid-float-exponent-with-suffix.vert
> +++ b/tests/spec/glsl-1.20/compiler/literals/valid-float-exponent-with-suffix.vert
> @@ -3,6 +3,8 @@
>  // glsl_version: 1.20
>  // [end config]
> 
> +#version 120
> +
>  void main() {
>         vec4 f = vec4(1e5f, -1e5f, 1e-5f, -1e-5f);
>         vec4 g = vec4(1e5F, -1e5F, 1e-5F, -1e-5F);
> diff --git a/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-capital-f.vert b/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-capital-f.vert
> index 1173e3e..594a73d 100644
> --- a/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-capital-f.vert
> +++ b/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-capital-f.vert
> @@ -3,6 +3,8 @@
>  // glsl_version: 1.20
>  // [end config]
> 
> +#version 120
> +
>  void main() {
>         float f = 1.0F;
>         gl_Position = vec4(1.0);
> diff --git a/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-f.vert b/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-f.vert
> index 8c910b2..ed518a4 100644
> --- a/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-f.vert
> +++ b/tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-f.vert
> @@ -3,6 +3,8 @@
>  // glsl_version: 1.20
>  // [end config]
> 
> +#version 120
> +
>  void main() {
>         float f = 1.0f;
>         gl_Position = vec4(1.0);
> --
> 2.5.5
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit

Thanks for these fixes, I'll add my reviewed-by and push.

Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160325/d14a26a3/attachment.sig>


More information about the Piglit mailing list