[Piglit] [PATCH] Drop floating point suffix from a GLSL 1.10 shader.

Kenneth Graunke kenneth at whitecape.org
Tue Mar 29 05:30:00 UTC 2016


The 'f' suffix isn't required, and in fact it isn't technically allowed
in GLSL 1.10 either.

Cc: Lars Hamre <chemecse at gmail.com>
---
 tests/spec/arb_texture_cube_map_array/cubemap-lod.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Hi Lars,

I noticed this Piglit test regressed when applying your Mesa patch.
It turns out the test was broken :)

 --Ken

diff --git a/tests/spec/arb_texture_cube_map_array/cubemap-lod.c b/tests/spec/arb_texture_cube_map_array/cubemap-lod.c
index ceb347b..2816f9e 100644
--- a/tests/spec/arb_texture_cube_map_array/cubemap-lod.c
+++ b/tests/spec/arb_texture_cube_map_array/cubemap-lod.c
@@ -80,7 +80,7 @@ static const char *frag_shader_biased =
  "uniform samplerCubeArray tex; \n"
  "void main()\n"
  "{\n"
- " gl_FragColor = texture(tex, gl_TexCoord[0], 3.0f);\n"
+ " gl_FragColor = texture(tex, gl_TexCoord[0], 3.0);\n"
  "}\n";
 
 static const char *frag_shader_explicit =
@@ -88,7 +88,7 @@ static const char *frag_shader_explicit =
  "uniform samplerCubeArray tex; \n"
  "void main()\n"
  "{\n"
- " gl_FragColor = textureLod(tex, gl_TexCoord[0], 3.0f);\n"
+ " gl_FragColor = textureLod(tex, gl_TexCoord[0], 3.0);\n"
  "}\n";
 
 static GLuint frag_shader_cube_array_biased;
-- 
2.7.4



More information about the Piglit mailing list