[Piglit] [PATCH 0/6] Cleanup and prepare for pre OpenGL 3.0 drivers

[Jose Fonseca]

On 30/03/16 11:14, Emil Velikov wrote:
> On 29 March 2016 at 23:53, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Isn't this backwards? Shouldn't waffle just work without the
>> ARB_create_context or whatever ext and just create a context and see
>> what version it is?
>>
> It isn't, imho.
>
> Waffle follows the GL winsys semantics, as such it should not do more
> (create a context, make it current, etc) unless explicitly asked. It
> translates the winsys/platform specifics, not the GL crazy. Although I
> can see how one would want both to be hidden/handled in waffle.
>
> That's my take on it, at least. If people familiar with waffle think
> I've misunderstood things, please shout.
>
> -Emil

FWIW, I agree with Ilia.  Ideally Waffle should abstract away these sort 
of behavioral differences.

On Mac, there isn't even WGL/GLX_ARB_create_context equivalent.

Furthermore, not setting WAFFLE_CONTEXT_DEBUG for 2.x context is IMO a 
functionality regression here.  Many implementations support debug for 
2.x contexts, and it can be quite useful for diagnosing issues.


So when a app requests a context <= 3.0: if the OpenGL implementation 
supports WGL/GLX_ARB_create_context waffle should use it.  If not, it 
should request a ordinary context, and check the version matches the 
requested.


Jose