[Piglit] [PATCH] arb_internalformat_query2: Fix memory leaks.

Alejandro Piñeiro apinheiro at igalia.com
Thu Mar 31 06:43:33 UTC 2016


Thanks

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>

On 31/03/16 02:39, Vinson Lee wrote:
> Fix resource leak defects reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_internalformat_query2/max-dimensions.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_internalformat_query2/max-dimensions.c b/tests/spec/arb_internalformat_query2/max-dimensions.c
> index 8825d84..e3369be 100644
> --- a/tests/spec/arb_internalformat_query2/max-dimensions.c
> +++ b/tests/spec/arb_internalformat_query2/max-dimensions.c
> @@ -353,6 +353,7 @@ check_max_dimension(const GLenum pname,
>  
>          piglit_report_subtest_result(pass ? PIGLIT_PASS : PIGLIT_FAIL,
>                                       "%s", piglit_get_gl_enum_name(pname));
> +        test_data_clear(&data);
>          return pass;
>  }
>  
> @@ -402,7 +403,7 @@ check_params_against_dimension(test_data *data,
>                                 const GLenum target,
>                                 const GLenum internalformat)
>  {
> -        test_data *local_data = test_data_clone(data);
> +        test_data *local_data;
>          GLenum dimension_pname;
>          bool result = true;
>  
> @@ -415,6 +416,8 @@ check_params_against_dimension(test_data *data,
>                  dimension_pname = GL_MAX_DEPTH;
>          }
>  
> +        local_data = test_data_clone(data);
> +
>          test_data_execute(local_data, target, internalformat,
>                            dimension_pname);
>  
> @@ -512,6 +515,7 @@ check_max_layers()
>  
>          piglit_report_subtest_result(pass ? PIGLIT_PASS : PIGLIT_FAIL,
>                                       "%s", piglit_get_gl_enum_name(GL_MAX_LAYERS));
> +        test_data_clear(&data);
>          return pass;
>  }
>  
> @@ -670,6 +674,7 @@ check_max_combined_dimensions()
>  
>          piglit_report_subtest_result(pass ? PIGLIT_PASS : PIGLIT_FAIL,
>                                       "%s", piglit_get_gl_enum_name(GL_MAX_COMBINED_DIMENSIONS));
> +        test_data_clear(&data);
>          return pass;
>  }
>  



More information about the Piglit mailing list