[Piglit] [PATCH 36/37] glean/tfragprog1: remove stress tests

Dylan Baker dylan at pnwbakers.com
Mon May 2 21:59:38 UTC 2016


These test divide by zero and divide by HUGE_NUMBER and -HUGE_NUMBER,
which don't seem particularly useful, especially since there are already
tests for that in GLSL, and if it's going to be a problem it'll be in
the compiler.

Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
---
 tests/all.py               |  2 --
 tests/glean/tfragprog1.cpp | 35 -----------------------------------
 2 files changed, 37 deletions(-)

diff --git a/tests/all.py b/tests/all.py
index 9a21616..8a67a18 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -376,8 +376,6 @@ glean_glsl_tests = ['Primary plus secondary color',
                     'texcoord varying']
 
 glean_fp_tests = [
-                  'Divide by zero test',
-                  'Infinity and nan test',
 ]
 
 glean_vp_tests = ['ABS test',
diff --git a/tests/glean/tfragprog1.cpp b/tests/glean/tfragprog1.cpp
index 340da20..248169a 100644
--- a/tests/glean/tfragprog1.cpp
+++ b/tests/glean/tfragprog1.cpp
@@ -81,41 +81,6 @@ static GLfloat FogCoord = 50.0;  /* Between FogStart and FogEnd */
 // These are the specific fragment programs which we'll test
 // Alphabetical order, please
 static const FragmentProgram Programs[] = {
-	// ============= Numeric stress tests =================================
-	// Basically just check that we don't crash when we do divides by
-	// zero, etc.
-	{
-		"Divide by zero test",
-		"!!ARBfp1.0\n"
-		"PARAM zero = program.local[0]; \n"
-		"RCP result.color.x, zero.x; \n"
-		"RCP result.color.y, zero.y; \n"
-		"RCP result.color.z, zero.z; \n"
-		"RCP result.color.w, zero.w; \n"
-		"END \n",
-		{ DONT_CARE_COLOR,
-		  DONT_CARE_COLOR,
-		  DONT_CARE_COLOR,
-		  DONT_CARE_COLOR
-		},
-		DONT_CARE_Z
-	},
-	{
-		"Infinity and nan test",
-		"!!ARBfp1.0\n"
-		"PARAM zero = program.local[0]; \n"
-		"PARAM infNan = program.local[9]; \n"
-		"ADD result.color, infNan, zero; \n"
-		"END \n",
-		{ DONT_CARE_COLOR,
-		  DONT_CARE_COLOR,
-		  DONT_CARE_COLOR,
-		  DONT_CARE_COLOR
-		},
-		DONT_CARE_Z
-	},
-
-	// XXX add lots more tests here!
 	{ NULL, NULL, {0,0,0,0}, 0 } // end of list sentinal
 };
 
-- 
2.8.2



More information about the Piglit mailing list