[Piglit] [PATCH] builtin_function*py: more test data for "trunc"
agomez at igalia.com
Wed May 4 11:17:09 UTC 2016
On Tue, 2016-05-03 at 12:39 -0700, Eric Anholt wrote:
> Andres Gomez <agomez at igalia.com> writes:
> > When performing a trunc op in a float value there is, basically,
> > three
> > scenarios: when the exponent is < 0, when it is > bitsize of the
> > significand or with a value in the middle. Current generator was
> > using
> > data for values in the middle and < 0 but not for the last case so
> > we
> > add now a couple of values in that range and also the interesting
> > 0.0
> > special value.
> Yeah, the testing for trunc/floor/ceil are really weak. It would
> be relevant to test values with exponents >= 32, to catch
> implementations trying to use casting to an integer.
Yes, that makes sense. I will take that into account for a future
patch. Right now there are some problems when using very big values
regarding the tolerance calculation algorithm.
Actually, I have to send an email with doubts about the usage of the
tolerance so we can discuss about that there. Hopefully, coming soon.
More information about the Piglit