[Piglit] [PATCH] framework/backends/junit: Fix invalid JUnit output

[Mark Janes]

Reviewed-by: Mark Janes <mark.a.janes at intel.com>

Dylan Baker <dylan at pnwbakers.com> writes:

> In commit b0d05323e code was added to produce clearer error messages for
> tests who's status changed from crash to fail and vice versa. There is a
> not so subtle bug in that patch, it adds a "crash" element, but that
> element should be an "error" element.
>
> This patch fixes that bug.
>
> cc: Kenneth Graunke <kenneth at whitecape.org>
> cc: Mark Janes <mark.a.janes at intel.com>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com
> ---
>  framework/backends/junit.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/framework/backends/junit.py b/framework/backends/junit.py
> index 8263d98..4b3d87e 100644
> --- a/framework/backends/junit.py
> +++ b/framework/backends/junit.py
> @@ -168,9 +168,9 @@ class JUnitBackend(FileBackend):
>                  elif expected_result == 'failure':
>                      err.text += \
>                          "\n\nERROR: Test should have been failure but was crash"
> -                    res = etree.SubElement(element, 'crash',
> +                    res = etree.SubElement(element, 'error',
>                                             message='expected failure, but got '
> -                                                   'crash')
> +                                                   'error')
>                  else:
>                      res = etree.SubElement(element, 'error')
>  
> -- 
> 2.8.2