[Piglit] [PATCH 2/2] framework/results: Fix subtests masking crashes
imirkin at alum.mit.edu
Tue May 10 21:32:59 UTC 2016
On Tue, May 10, 2016 at 5:32 PM, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Ilia Mirkin (2016-05-10 06:41:33)
>> Shouldn't the test's result just be included into the "max" no matter what?
> Well, the problem is that a lot of tests were retrofitted with subtests,
> and now the overall status is bunk, and for new tests we generally don't
> add an overall result when there's subtests.
It's surprising if the status of a test says fail but piglit-summary
reports it as pass. In the case where one of the subtests fails but
the overall status is pass, this would still say fail, no?
What situation are you protecting against by only incorporating the
overall status on crash?
More information about the Piglit