[Piglit] [PATCH] arb_query_buffer_object: Fix format-security warning.

Dylan Baker dylan at pnwbakers.com
Wed May 11 01:01:50 UTC 2016


Quoting Vinson Lee (2016-05-10 17:48:07)
> qbo.c: In function ‘run_subtest_and_present’:
> qbo.c:269:2: warning: format not a string literal and no format arguments [-Wformat-security]
>   piglit_report_subtest_result(r, subtest_name);
>   ^
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_query_buffer_object/qbo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_query_buffer_object/qbo.c b/tests/spec/arb_query_buffer_object/qbo.c
> index bd47dd2a3989..1bcbe1035fad 100644
> --- a/tests/spec/arb_query_buffer_object/qbo.c
> +++ b/tests/spec/arb_query_buffer_object/qbo.c
> @@ -266,7 +266,7 @@ run_subtest_and_present(void)
>         asprintf(&subtest_name, "query-%s-%s",
>                  piglit_get_gl_enum_name(query_type),
>                  sync_mode_names[sync_mode]);
> -       piglit_report_subtest_result(r, subtest_name);
> +       piglit_report_subtest_result(r, "%s", subtest_name);
>         free(subtest_name);
>         return r;
>  }
> -- 
> 2.7.4
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160510/8070159c/attachment.sig>


More information about the Piglit mailing list