[Piglit] [PATCH] shader_runner: Initialize gl_max_varying_components more often.

Kenneth Graunke kenneth at whitecape.org
Wed May 18 09:06:01 UTC 2016


On Tuesday, May 17, 2016 6:09:26 PM PDT Eric Anholt wrote:
> Back in the day it was called MAX_VARYING_FLOATS, which is an alias
> for MAX_VARYING_COMPONENTS.  Fixes a bunch of varying-components tests
> skipping on vc4.
> ---
>  tests/shaders/shader_runner.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index 239735cba1c9..b1d30185a29c 100644
> --- a/tests/shaders/shader_runner.c
> +++ b/tests/shaders/shader_runner.c
> @@ -3326,7 +3326,8 @@ piglit_init(int argc, char **argv)
>  	    piglit_is_extension_supported("GL_ARB_vertex_shader"))
>  		glGetIntegerv(GL_MAX_VERTEX_UNIFORM_COMPONENTS,
>  			      &gl_max_vertex_uniform_components);
> -	if (piglit_get_gl_version() >= 30 ||
> +	if (piglit_get_gl_version() >= 20 ||
> +	    piglit_is_extension_supported("GL_ARB_vertex_shader") ||
>  	    piglit_is_extension_supported("GL_ARB_geometry_shader4") ||
>  	    piglit_is_extension_supported("GL_EXT_geometry_shader4"))
>  		glGetIntegerv(GL_MAX_VARYING_COMPONENTS,
> 

Yep, MAX_VARYING_FLOATS does indeed alias MAX_VARYING_COMPONENTS and
existed in OpenGL 2.0.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160518/53f65cff/attachment.sig>


More information about the Piglit mailing list