[Piglit] [PATCH] tests: Add integration with Khronos CTS OpenGL runner

[Dylan Baker]

Quoting Juan A. Suarez Romero (2016-05-18 09:27:34)
> On Wed, 2016-05-18 at 09:20 -0700, Dylan Baker wrote:
> > Quoting Juan A. Suarez Romero (2016-05-18 06:34:07)
> > > This adds support for running Khronos' deqp-based conformance suite
> > for
> > > OpenGL with piglit.
> > > ---
> > >  piglit.conf.example             | 10 ++++++++++
> > >  tests/{cts.py => cts_gl45.py}   | 43 +++++++++++++++++++++++++--
> > --------------
> > >  tests/{cts.py => cts_gles31.py} |  2 +-
> > 
> > Since these run all of the tests I think I'd prefer cts_gles and
> > cts_gl,
> > but that's a bit of a nit-pick.
> 
> What about the envvars / piglit.conf?
> 
> I keep PIGLIT_CTS_BIN for gles, while using PIGLIT_CTS_GL_BIN for gl.
> 
> Does it make sense to rename the envvar and use also
> PIGLIT_CTS_GLES_BIN / PIGLIT_CTS_GLES_EXTRA_ARGS for gles, and
> PIGLIT_CTS_GL_BIN / PIGLIT_CTS_GL_EXTRA_ARGS for gl?
> 
> 
>         J.A.

I'm 50/50 on it. While I think it probably is nicer to change them, it
also creates more churn for people using the functionality.

My r-b remains whichever way you decide to go.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160518/e3115ac7/attachment-0001.sig>