[Piglit] [PATCH 0/3] Fix some program input / output issues with ARB_piq

[Martin Peres]

On 26/05/16 21:56, Ian Romanick wrote:
> On 05/26/2016 11:55 AM, Ian Romanick wrote:
>> On 05/26/2016 08:01 AM, Martin Peres wrote:
>>> On 26/05/16 01:36, Ian Romanick wrote:
>>>> After spending about a week with dEQP, GL_OES_shader_io_blocks, and
>>>> GL_OES_geometry_shader, I believe there are some errors with the
>>>> expectations of our existing ARB_piq tests.  I have included spec
>>>> justifications for the changes, and the changes match tests that I have
>>>> seen in dEQP.
>>>>
>>>> I would really like to know the before / after results of the updated
>>>> test on modern NVIDIA and AMD closed-source drivers.
>>>
>>> Thanks for doing this! Here are the result on GeForce GT 430/PCIe/SSE2,
>>> NVIDIA 355.11
>>>
>>> $ ./piglit summary console -d before/ after
>>> spec/arb_program_interface_query/arb_program_interface_query-resource-query/GL_PROGRAM_INPUT(gs):
>>> pass fail
>>> spec/arb_program_interface_query/arb_program_interface_query-resource-query/GL_PROGRAM_INPUT(gs,fs):
>>> pass fail
>>> spec/arb_program_interface_query/arb_program_interface_query-resource-query/GL_PROGRAM_INPUT(tcs):
>>> pass fail
>>> spec/arb_program_interface_query/arb_program_interface_query-resource-query/GL_PROGRAM_INPUT(tcs,tes):
>>> pass fail
>>> spec/arb_program_interface_query/arb_program_interface_query-resource-query/GL_PROGRAM_INPUT(tes):
>>> pass fail
>>
>> Interesting... is it just that they don't have gl_PerVertex on things,
>> or is the arrayness also different?  I want to put proper annotations in
>> the commit messages.
>
> If you want to just send the output of "after"
> 'bin/arb_program_interface_query-resource-query -auto' on that system, I
> should be able to figure out what to put in the commit message.


Sorry for the delay, I was already home when I saw your email. Here it is:

bin/arb_program_interface_query-resource-query -auto -fbo
PIGLIT: {"subtest": {"GL_UNIFORM(vs,gs,fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_UNIFORM(tes,tcs)" : "pass"}}
PIGLIT: {"subtest": {"GL_UNIFORM(cs)" : "pass"}}
PIGLIT: {"subtest": {"GL_UNIFORM_BLOCK(vs,gs,fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_UNIFORM_BLOCK(tcs,tes)" : "pass"}}
PIGLIT: {"subtest": {"GL_UNIFORM_BLOCK(cs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(vs)" : "pass"}}
'GL_PROGRAM_INPUT(gs) max length name' expected 25 but got 12
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(gs)" : "fail"}}
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(vs,fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(vs,gs)" : "pass"}}
'GL_PROGRAM_INPUT(gs,fs) max length name' expected 25 but got 12
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(gs,fs)" : "fail"}}
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(vs,gs,fs)" : "pass"}}
'GL_PROGRAM_INPUT(tes) max length name' expected 25 but got 12
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(tes)" : "fail"}}
'GL_PROGRAM_INPUT(tcs) active resources' expected 3 but got 2
'GL_PROGRAM_INPUT(tcs) max length name' expected 25 but got 12
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(tcs)" : "fail"}}
'GL_PROGRAM_INPUT(tcs,tes) active resources' expected 3 but got 2
'GL_PROGRAM_INPUT(tcs,tes) max length name' expected 25 but got 12
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(tcs,tes)" : "fail"}}
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(vs,tcs,tes)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_INPUT(cs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(vs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(gs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(vs,fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(vs,gs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(gs,fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(vs,gs,fs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(tes)" : "pass"}}
'GL_PROGRAM_OUTPUT(tcs) active resources' expected 3 but got 2
'GL_PROGRAM_OUTPUT(tcs) max length name' expected 25 but got 12
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(tcs)" : "fail"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(tcs,tes)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(tcs,tes,gs)" : "pass"}}
PIGLIT: {"subtest": {"GL_PROGRAM_OUTPUT(cs)" : "pass"}}
PIGLIT: {"subtest": {"GL_BUFFER_VARIABLE" : "pass"}}
PIGLIT: {"subtest": {"GL_SHADER_STORAGE_BLOCK" : "pass"}}
PIGLIT: {"subtest": {"GL_ATOMIC_COUNTER_BUFFER" : "pass"}}
PIGLIT: {"subtest": {"GL_TRANSFORM_FEEDBACK_VARYING" : "pass"}}
PIGLIT: {"subtest": {"GL_VERTEX_SUBROUTINE" : "pass"}}
PIGLIT: {"subtest": {"GL_GEOMETRY_SUBROUTINE" : "pass"}}
PIGLIT: {"subtest": {"GL_FRAGMENT_SUBROUTINE" : "pass"}}
PIGLIT: {"subtest": {"GL_COMPUTE_SUBROUTINE" : "pass"}}
PIGLIT: {"subtest": {"GL_TESS_CONTROL_SUBROUTINE" : "pass"}}
PIGLIT: {"subtest": {"GL_TESS_EVALUATION_SUBROUTINE" : "pass"}}
PIGLIT: {"subtest": {"GL_VERTEX_SUBROUTINE_UNIFORM" : "pass"}}
PIGLIT: {"subtest": {"GL_GEOMETRY_SUBROUTINE_UNIFORM" : "pass"}}
PIGLIT: {"subtest": {"GL_FRAGMENT_SUBROUTINE_UNIFORM" : "pass"}}
PIGLIT: {"subtest": {"GL_TESS_CONTROL_SUBROUTINE_UNIFORM" : "pass"}}
PIGLIT: {"subtest": {"GL_TESS_EVALUATION_SUBROUTINE_UNIFORM" : "pass"}}
PIGLIT: {"subtest": {"GL_COMPUTE_SUBROUTINE_UNIFORM" : "pass"}}
PIGLIT: {"result": "fail" }