[Piglit] Piglit is broken

[Dylan Baker]

Quoting Marek Olšák (2016-11-08 11:26:04)
> Hi,
> 
> Piglit has started failing at startup. Not sure why. I'm not able to
> find a good commit.
> 
> Command:
> PIGLIT_NO_FAST_SKIP=1 \
>     ./piglit run --process-isolation 0 -p gbm quick
> 
> Traceback (most recent call last):
>   File "./piglit", line 174, in <module>
>     main()
>   File "./piglit", line 166, in main
>     returncode = parsed.func(args)
>   File "/home/marek/dev/piglit/framework/exceptions.py", line 51, in _inner
>     func(*args, **kwargs)
>   File "/home/marek/dev/piglit/framework/programs/run.py", line 323, in run
>     profile = framework.profile.merge_test_profiles(args.test_profile)
>   File "/home/marek/dev/piglit/framework/profile.py", line 528, in
> merge_test_profiles
>     profile = load_test_profile(profiles.pop())
>   File "/home/marek/dev/piglit/framework/profile.py", line 506, in
> load_test_profile
>     os.path.splitext(os.path.basename(filename))[0]))
>   File "/usr/lib/python3.5/importlib/__init__.py", line 126, in import_module
>     return _bootstrap._gcd_import(name[level:], package, level)
>   File "<frozen importlib._bootstrap>", line 986, in _gcd_import
>   File "<frozen importlib._bootstrap>", line 969, in _find_and_load
>   File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
>   File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
>   File "<frozen importlib._bootstrap_external>", line 665, in exec_module
>   File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
>   File "/home/marek/dev/piglit/tests/quick.py", line 9, in <module>
>     from tests.all import profile
>   File "/home/marek/dev/piglit/tests/all.py", line 267, in <module>
>     profile.test_list[group] = MultiShaderTest(files)
>   File "/home/marek/dev/piglit/framework/test/shader_test.py", line
> 203, in __init__
>     assert parser.prog == prog
> AssertionError
> 
> 
> Also, removing PIGLIT_NO_FAST_SKIP=1 gives a different failure. This
> has never worked for me, perhaps it shouldn't be enabled by default:
> 
> Traceback (most recent call last):
>   File "./piglit", line 174, in <module>
>     main()
>   File "./piglit", line 166, in main
>     returncode = parsed.func(args)
>   File "/home/marek/dev/piglit/framework/exceptions.py", line 51, in _inner
>     func(*args, **kwargs)
>   File "/home/marek/dev/piglit/framework/programs/run.py", line 323, in run
>     profile = framework.profile.merge_test_profiles(args.test_profile)
>   File "/home/marek/dev/piglit/framework/profile.py", line 528, in
> merge_test_profiles
>     profile = load_test_profile(profiles.pop())
>   File "/home/marek/dev/piglit/framework/profile.py", line 506, in
> load_test_profile
>     os.path.splitext(os.path.basename(filename))[0]))
>   File "/usr/lib/python3.5/importlib/__init__.py", line 126, in import_module
>     return _bootstrap._gcd_import(name[level:], package, level)
>   File "<frozen importlib._bootstrap>", line 986, in _gcd_import
>   File "<frozen importlib._bootstrap>", line 969, in _find_and_load
>   File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
>   File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
>   File "<frozen importlib._bootstrap_external>", line 665, in exec_module
>   File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
>   File "/home/marek/dev/piglit/tests/quick.py", line 9, in <module>
>     from tests.all import profile
>   File "/home/marek/dev/piglit/tests/all.py", line 267, in <module>
>     profile.test_list[group] = MultiShaderTest(files)
>   File "/home/marek/dev/piglit/framework/test/shader_test.py", line
> 213, in __init__
>     skipper.test()
>   File "/home/marek/dev/piglit/framework/test/opengl.py", line 364, in test
>     if (self.info.glsl_version is not None
>   File "/home/marek/dev/piglit/framework/core.py", line 230, in __get__
>     value = self.__func(instance)
>   File "/home/marek/dev/piglit/framework/test/opengl.py", line 256, in
> glsl_version
>     'OpenGL shading language').split()[-1][:4])
>   File "/home/marek/dev/piglit/framework/test/opengl.py", line 116, in __getline
>     raise Exception('Unreachable')
> Exception: Unreachable
> 
> Thanks,
> Marek
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit

It's d81536a3c5989b6, which puts tests in a folder structure that breaks one of
the assumptions of the python layer.  I don't think this is that hard to fix.
Hopefully I'll have a patch for you shortly. Oh, and this only breaks with
--process-isolation false, you can work around it in the short term by removing
that flag.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161108/9e9cfb74/attachment.sig>