[Piglit] [PATCH] tests/quick.py: reduce the number of vs_in tests in quick.py

Dylan Baker dylan at pnwbakers.com
Thu Nov 10 17:39:02 UTC 2016


Quoting Andres Gomez (2016-11-10 01:06:57)
> On Wed, 2016-11-09 at 14:56 -0800, Dylan Baker wrote:
> > Bump.
> > 
> > Anyone interested in this?
> > 
> > 
> 
> As commented, although this is not a definitive solution I suppose this
> can help in the meanwhile.
> 
> I'm sorry I didn't contribute a follow up. I got tangled in other tasks
> and never found time to get to it.
> 
> In any case, my idea was to reduce the amount of tested cases since I
> think right now there are probably many tests that check very similar
> inputs. Additionally, I was thinking on something like this for the
> quick profile so this works for me.

That might be a better short term solution than this patch, since it shouldn't
be that hard to do, unlike a C test that would take someone an investment of
time to create. I think in the short term I'll land this to make quick.py
quicker, it's not very invasive and we can remove it easily enough.

> 
> However, maybe a C test could be a better idea, dunno.
> 
> From my side, this is:
> 
> Reviewed-by: Andres Gomez <agomez at igalia.com>

Thanks!

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161110/f0ff8194/attachment.sig>


More information about the Piglit mailing list