[Piglit] [PATCH v2 2/2] util: implement eventloop for wayland platform

[Pekka Paalanen]

On Tue, 15 Nov 2016 12:06:35 +0200
Tapani Pälli <tapani.palli at intel.com> wrote:

> On 11/15/2016 10:29 AM, Pekka Paalanen wrote:
> > On Wed,  2 Nov 2016 13:16:27 +0200
> > Tapani Pälli <tapani.palli at intel.com> wrote:
> >  
> >> v2: lots of fixes based on review from Pekka Paalanen
> >>
> >>     - fix leak of fd in keymap handler
> >>     - fix leak of wayland registry
> >>     - just call wl_display_dispatch in process_events
> >>     - act when key pressed (matches x11 backend behavior)
> >>     - just pass any keys, now tests that do special stuff
> >>       with keys work (like fbo-clear-formats)
> >>
> >> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> >> ---
> >>  .../util/piglit-framework-gl/piglit_wl_framework.c | 253 +++++++++++++++++++--
> >>  1 file changed, 237 insertions(+), 16 deletions(-)  

> > It all looks pretty good to me, just the couple freeing issues, and few
> > questions. I didn't compare this to what we have in Weston repository
> > nor do I know anything about Piglit's framework, but with that
> > disclaimer, I have nothing else to complain about. :-)
> >
> > Not sure that really counts as R-b...  
> 
> Thanks for taking a look!
> 
> If you want to still check/test I've pushed a v3 here with fixes to 
> issues you found:
> 
> https://cgit.freedesktop.org/~tpalli/piglit/log/?h=wayland
> 
> If nobody complains, I'll push this in after some days.

Hi,

the event loop patch looks fine to me, so that one gets:
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
with the aforementioned disclaimers.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161115/97873eaf/attachment.sig>