[Piglit] [PATCH] arb_compute_variable_group_size: Add argument to piglit_subtest functions.

[Samuel Pitoiset]

I wonder if Clang also warns about that.

Anyway, nicely spotted, thanks!

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 11/23/2016 01:16 AM, Vinson Lee wrote:
> Fix Intel C++ Compiler warnings.
>
> errors.c(223): warning #144: a value of type "enum piglit_result (*)()" cannot be used to initialize an entity of type "enum piglit_result (*)(void *)"
>   		use_variable_work_group_size_normal,
>   		^
>
> errors.c(229): warning #144: a value of type "enum piglit_result (*)()" cannot be used to initialize an entity of type "enum piglit_result (*)(void *)"
>   		use_variable_work_group_size_indirect,
>   		^
>
> errors.c(236): warning #144: a value of type "enum piglit_result (*)()" cannot be used to initialize an entity of type "enum piglit_result (*)(void *)"
>   		use_fixed_work_group_size,
>   		^
>
> errors.c(242): warning #144: a value of type "enum piglit_result (*)()" cannot be used to initialize an entity of type "enum piglit_result (*)(void *)"
>   		use_invalid_work_group_count_values,
>   		^
>
> errors.c(248): warning #144: a value of type "enum piglit_result (*)()" cannot be used to initialize an entity of type "enum piglit_result (*)(void *)"
>   		use_invalid_variable_work_group_size_values,
>   		^
>
> errors.c(254): warning #144: a value of type "enum piglit_result (*)()" cannot be used to initialize an entity of type "enum piglit_result (*)(void *)"
>   		use_invalid_variable_group_invocations_values,
>   		^
>
> Fixes: ad38b44dd015 ("add ARB_compute_variable_group_size tests")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_compute_variable_group_size/errors.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tests/spec/arb_compute_variable_group_size/errors.c b/tests/spec/arb_compute_variable_group_size/errors.c
> index 82bae42..68b06c3 100644
> --- a/tests/spec/arb_compute_variable_group_size/errors.c
> +++ b/tests/spec/arb_compute_variable_group_size/errors.c
> @@ -62,7 +62,7 @@ static const char *fixed_work_group_size_shader =
>  	"}\n";
>
>  static enum piglit_result
> -use_variable_work_group_size_normal()
> +use_variable_work_group_size_normal(void *data)
>  {
>  	/* The ARB_compute_variable_group_size spec says:
>  	 *
> @@ -80,7 +80,7 @@ use_variable_work_group_size_normal()
>  }
>
>  static enum piglit_result
> -use_variable_work_group_size_indirect()
> +use_variable_work_group_size_indirect(void *data)
>  {
>  	/* The ARB_compute_variable_group_size spec says:
>  	 *
> @@ -114,7 +114,7 @@ use_variable_work_group_size_indirect()
>  }
>
>  static enum piglit_result
> -use_fixed_work_group_size()
> +use_fixed_work_group_size(void *data)
>  {
>  	/* The ARB_compute_variable_group_size spec says:
>  	 *
> @@ -132,7 +132,7 @@ use_fixed_work_group_size()
>  }
>
>  static enum piglit_result
> -use_invalid_work_group_count_values()
> +use_invalid_work_group_count_values(void *data)
>  {
>  	GLint prog, v[3];
>
> @@ -158,7 +158,7 @@ use_invalid_work_group_count_values()
>  }
>
>  static enum piglit_result
> -use_invalid_variable_work_group_size_values()
> +use_invalid_variable_work_group_size_values(void *data)
>  {
>  	/* The ARB_compute_variable_group_size spec says:
>  	 *
> @@ -192,7 +192,7 @@ use_invalid_variable_work_group_size_values()
>  }
>
>  static enum piglit_result
> -use_invalid_variable_group_invocations_values()
> +use_invalid_variable_group_invocations_values(void *data)
>  {
>  	/* The ARB_compute_variable_group_size spec says:
>  	 *
>

-- 
-Samuel