[Piglit] [PATCH] arb_program_interface_query: Silence return-type warning.

Tapani Pälli tapani.palli at intel.com
Tue Oct 4 07:26:12 UTC 2016



On 10/04/2016 03:34 AM, Vinson Lee wrote:
> compare-with-shader-subroutine.c: In function 'get_shadertype_from_program_interface':
> compare-with-shader-subroutine.c:251:1: warning: control reaches end of non-void function [-Wreturn-type]
>  }
>  ^
>
> Fixes: 39ccf8c59bd5 ("arb_program_interface_query: add compare-with-shader-subroutine test")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_program_interface_query/compare-with-shader-subroutine.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/spec/arb_program_interface_query/compare-with-shader-subroutine.c b/tests/spec/arb_program_interface_query/compare-with-shader-subroutine.c
> index 2ac9da9..4c52ea7 100644
> --- a/tests/spec/arb_program_interface_query/compare-with-shader-subroutine.c
> +++ b/tests/spec/arb_program_interface_query/compare-with-shader-subroutine.c
> @@ -247,6 +247,7 @@ get_shadertype_from_program_interface(const GLenum programInterface)
>                  return GL_COMPUTE_SHADER;
>          default:
>                  assert(!"unexpected programInterface value");
> +                return GL_VERTEX_SHADER;

I'd prefer GL_INVALID_ENUM but not a big deal ..

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>


More information about the Piglit mailing list