[Piglit] [PATCH] tests/igt: dmesg noise is a kernel failure

Daniel Vetter daniel.vetter at ffwll.ch
Fri Oct 7 07:06:31 UTC 2016


At least when testing the kernel. In normal programs pretty much all
the dmesg noise would simply be replaced by debug asserts, but in the
kernel we try rely hard to not fall over minor inconsistencies.

Still for CI purposes there's not really a difference, hence don't
treat it as such.

Motivated since once again I've seen a statistics where this was split
up, and then a reduction of "failures" (but in reality just trading
them in for more "warnings") praised as success.

v2: Clamp to "dmesg-fail" to keep dmesg noise easily identifiable
(Ville).

Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Acked-by: Dylan Baker <dylan at pnwbakers.com>
Cc: jari.tahvanainen at intel.com
Cc: Petri Latvala <petri.latvala at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 tests/igt.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/igt.py b/tests/igt.py
index 7ebb03646b50..21e55e115654 100644
--- a/tests/igt.py
+++ b/tests/igt.py
@@ -123,6 +123,10 @@ class IGTTest(Test):
         else:
             self.result.result = 'fail'
 
+        # all dmesg noise is considered a test failure when testing the kernel
+        if self.result.dmesg
+            self.result.result = 'dmesg-fail'
+
 
 def list_tests(listname):
     """Parse igt test list and return them as a list."""
-- 
2.9.3



More information about the Piglit mailing list