[Piglit] [PATCH] shader_runner: report PIGLIT_FAIL if linking unexpectedly fails

Dylan Baker dylan at pnwbakers.com
Wed Oct 19 18:13:51 UTC 2016


Quoting Brian Paul (2016-10-18 17:18:55)
> We were previously reporting 'pass' if linking failed.
> 
> v2: return the result of program_must_be_in_use(), per Dylan.
> ---
>  tests/shaders/shader_runner.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index b0bde2c..598a859 100644
> --- a/tests/shaders/shader_runner.c
> +++ b/tests/shaders/shader_runner.c
> @@ -3528,7 +3528,7 @@ piglit_display(void)
>         }
>  
>         if (!link_ok && !link_error_expected) {
> -               program_must_be_in_use();
> +               full_result = program_must_be_in_use();
>         }
>  
>         piglit_present_results();
> -- 
> 1.9.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161019/f879866b/attachment.sig>


More information about the Piglit mailing list